[
https://issues.apache.org/jira/browse/KNOX-2731?focusedWorklogId=756489&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-756489
]
ASF GitHub Bot logged work on KNOX-2731:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Apr/22 16:02
Start Date: 13/Apr/22 16:02
Worklog Time Spent: 10m
Work Description: zeroflag commented on code in PR #554:
URL: https://github.com/apache/knox/pull/554#discussion_r849654484
##########
gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/TokenResource.java:
##########
@@ -827,6 +837,10 @@ private Response getAuthenticationToken() {
return Response.ok().entity("{ \"Unable to acquire token.\" }").build();
}
+ private boolean shouldIncludeGroups() {
+ return
Boolean.parseBoolean(request.getParameter(KNOX_TOKEN_INCLUDE_GROUPS));
Review Comment:
It will default to false. The parseBoolean is implemented a follows:
```java
public static boolean parseBoolean(String s) {
return ((s != null) && s.equalsIgnoreCase("true"));
}
```
Issue Time Tracking
-------------------
Worklog Id: (was: 756489)
Time Spent: 2.5h (was: 2h 20m)
> Allow group membership information to be included in issued JWTs
> ----------------------------------------------------------------
>
> Key: KNOX-2731
> URL: https://issues.apache.org/jira/browse/KNOX-2731
> Project: Apache Knox
> Issue Type: Improvement
> Reporter: Attila Magyar
> Assignee: Attila Magyar
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
