lmccay commented on code in PR #1074:
URL: https://github.com/apache/knox/pull/1074#discussion_r2267699975
##########
gateway-server/src/main/java/org/apache/knox/gateway/UrlEncodedFormRequest.java:
##########
@@ -77,6 +78,9 @@ private MultiMap<String> parseQueryString(String queryString)
{
@Override
public String getParameter(String name) {
+ if(JWTFederationFilter.GRANT_TYPE.equals(name) ||
JWTFederationFilter.CLIENT_ID.equals(name) ||
JWTFederationFilter.CLIENT_SECRET.equals(name)) {
+ return super.getParameter(name);
+ }
return queryParams.getValue(name, 0);
Review Comment:
I am assuming there is some reason that we were limiting this to just the
query string but do you know why? If we checked whether queryParams contains
the name first then use that otherwise fall back to the parent then we don't
need to check that the name matches one of those three? I feel like if we
aren't violating the original intent of this method for those three then why
are we for any others?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
