lmccay commented on code in PR #1074:
URL: https://github.com/apache/knox/pull/1074#discussion_r2267806587
##########
gateway-server/src/main/java/org/apache/knox/gateway/UrlEncodedFormRequest.java:
##########
@@ -77,6 +78,9 @@ private MultiMap<String> parseQueryString(String queryString)
{
@Override
public String getParameter(String name) {
+ if(JWTFederationFilter.GRANT_TYPE.equals(name) ||
JWTFederationFilter.CLIENT_ID.equals(name) ||
JWTFederationFilter.CLIENT_SECRET.equals(name)) {
+ return super.getParameter(name);
+ }
return queryParams.getValue(name, 0);
Review Comment:
Interesting. Really makes me wonder about rewrites which can require request
body changes.
At any rate, I'll give my plus one for when other comments are resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
