Adar Dembo has posted comments on this change. Change subject: KUDU-1312: scan token protobuf message format ......................................................................
Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/2622/6/src/kudu/client/client.proto File src/kudu/client/client.proto: Line 26: message ScanTokenPB { Is it at all possible to reuse NewScanRequestPB? It's a shame that new fields added there will probably have to be duplicated here. Could you add a comment to the message definition itself explaining what it is at a high level? Line 40: optional string table_name = 2; Why optional? Isn't the name of the table a requirement? If not, could you explain why in a comment here? Line 58: // Encoded partition key to begin scanning at (inclusive). : optional bytes lower_bound_partition_key = 7; : : // Encoded partition key to stop scanning at (exclusive). : optional bytes upper_bound_partition_key = 8; These aren't in NewScanRequestPB. Why do we need them here and not there? Line 87: optional bool fault_tolerant = 14 [default = false]; Shouldn't this use OrderMode? Line 88: } Do we need last_primary_key too? -- To view, visit http://gerrit.cloudera.org:8080/2622 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09983d71c81a383cf4e0e24a49367c64960bbd4d Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
