Adar Dembo has posted comments on this change. Change subject: KUDU-1312: scan token protobuf message format ......................................................................
Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/2622/6/src/kudu/client/client.proto File src/kudu/client/client.proto: Line 40: optional string table_name = 2; > My understanding is that a protobuf best practice never use required fields Agreed, but I thought that only held when adding new fields to an existing message, not when adding a new message altogether. Line 58: // Encoded partition key to begin scanning at (inclusive). : optional bytes lower_bound_partition_key = 7; : : // Encoded partition key to stop scanning at (exclusive). : optional bytes upper_bound_partition_key = 8; > They aren't needed in NewScanRequestPB because that message is meant for se That's an important design decision (storing partition keys in lieu of a tablet ID so that tokens remain useful in the event of a tablet split); is it documented somewhere? If not, could you ensure it is documented? -- To view, visit http://gerrit.cloudera.org:8080/2622 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09983d71c81a383cf4e0e24a49367c64960bbd4d Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
