Adar Dembo has posted comments on this change. Change subject: KUDU-1312: scan token protobuf message format ......................................................................
Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/2622/6/src/kudu/client/client.proto File src/kudu/client/client.proto: Line 26: message ScanTokenPB { > It may be, but some of the fields don't match exactly. Todd was in favor of Makes sense. I think you missed the second thing I wrote, about wanting a message definition comment. -- To view, visit http://gerrit.cloudera.org:8080/2622 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09983d71c81a383cf4e0e24a49367c64960bbd4d Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
