Adar Dembo has posted comments on this change. Change subject: [c++-client] implement scan token API ......................................................................
Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/2757/6/src/kudu/client/scan_token-internal.cc File src/kudu/client/scan_token-internal.cc: Line 160: RETURN_NOT_OK(builder->Open()); > I did it this way to mirror the Java API: the returned scanner is fully for There's a difference, though: the Java scanner only starts sending RPCs in the first call to nextRows(). Until then all operations are local and fast (i.e. allocating things and setting internal fields). KuduScanner::Open() (C++) makes RPCs in a way that KuduScannerBuilder.build() (Java) does not. -- To view, visit http://gerrit.cloudera.org:8080/2757 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If28e653a9b28164741a3c6f36097f0b7c72e8162 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
