Adar Dembo has posted comments on this change. Change subject: [c++-client] implement scan token API ......................................................................
Patch Set 10: > (1 comment) I see. I'm not in love with the semantic change (which should be accompanied by a comment update to the KuduScanner constructor, no?), but I understand why you need it. An alternative would be to add another static method that opens the table using the given serialized ScanToken (or, a KuduClient overload for OpenTable whose input is a ScanToken). That would be useful if you think "task executors" would benefit from also having access to the table, which they can't get today from the scanner. But if you think executors only care about deserializing scan tokens into scanners, then it's unnecessary. And you could achieve the same thing by exposing something like KuduScanner::table() anyway. -- To view, visit http://gerrit.cloudera.org:8080/2757 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If28e653a9b28164741a3c6f36097f0b7c72e8162 Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
