Adar Dembo has posted comments on this change. Change subject: [c++-client] implement scan token API ......................................................................
Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/2757/9/src/kudu/client/scanner-internal.h File src/kudu/client/scanner-internal.h: Line 187: sp::shared_ptr<KuduTable> table_; What's the motivation for this change? KuduScanner's constructor explains how the KuduTable must outlive the scanner, so you shouldn't a shared pointer here. Moreover, it's weird that we use shared_from_this() when constructing KuduScanner::Data instead of passing a shared_ptr all the way from the KuduScanner constructor. -- To view, visit http://gerrit.cloudera.org:8080/2757 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If28e653a9b28164741a3c6f36097f0b7c72e8162 Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
