Dan Burkert has posted comments on this change. Change subject: KUDU-1364. Don't clear the cache when a server disconnect ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/2449/3/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java: Line 1906: int index = tabletServers.indexOf(staleTs); Is it possible that staleTs has already been removed at this point? http://gerrit.cloudera.org:8080/#/c/2449/3/java/kudu-client/src/main/java/org/kududb/client/TabletClient.java File java/kudu-client/src/main/java/org/kududb/client/TabletClient.java: Line 265: Channel chancopy = chan; Why is the copy necessary here? This is just another reference to the same object, right? http://gerrit.cloudera.org:8080/#/c/2449/3/java/kudu-client/src/test/java/org/kududb/client/ITClient.java File java/kudu-client/src/test/java/org/kududb/client/ITClient.java: Line 52: // Hatch used to track if an error occurred and we need to stop the test early. Is Hatch a typo? -- To view, visit http://gerrit.cloudera.org:8080/2449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8606bfcedb09af57b66ba0f065067f0f3335a4a8 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
