Adar Dembo has posted comments on this change.

Change subject: KUDU-1364. Don't clear the cache when a server disconnect
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/2449/5/java/kudu-client/src/test/java/org/kududb/client/ITClient.java
File java/kudu-client/src/test/java/org/kududb/client/ITClient.java:

Line 110:     Thread.sleep(FINAL_SLEEP_SECONDS);
You shouldn't need this; if you join on all of the threads (one by one), you'll 
guarantee that this thread only exits after all of the other threads are done.


Line 141:         KEEP_RUNNING_LATCH.await(2000, TimeUnit.SECONDS);
2000 seconds? You mean 2000 ms here?


-- 
To view, visit http://gerrit.cloudera.org:8080/2449
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8606bfcedb09af57b66ba0f065067f0f3335a4a8
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to