Adar Dembo has posted comments on this change. Change subject: KUDU-1364. Don't clear the cache when a server disconnect ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/2449/3/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java: Line 664: // Let fall through. > newTabletClient should be null, then fall through. Maybe change the comment Ah, it isn't clear (without looking at reconnectTabletClient()) that an exception here implies that newTabletClient will be null. So yes, I think adjusting the comment to explain what will happen is a good idea. http://gerrit.cloudera.org:8080/#/c/2449/3/java/kudu-client/src/test/java/org/kududb/client/ITClient.java File java/kudu-client/src/test/java/org/kududb/client/ITClient.java: Line 112: for (Thread thread : threads) { : thread.interrupt(); : } > The threads could also be stuck in sleeps inside the clients, even after gi We have sleep calls in the client? The only one I see is inside isAlterTableDone(). Are there others? -- To view, visit http://gerrit.cloudera.org:8080/2449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8606bfcedb09af57b66ba0f065067f0f3335a4a8 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
