Hi Liu ze, when you prepare the patch for 2.x, could you please draft a document describing the core idea, what is for and what it not for? That would give the reviewer an overall picture before diving into the codes. Thanks again for your contribution!
2016-01-26 15:57 GMT+08:00 Adunuthula, Seshu <[email protected]>: > Liu, > > Thank you for the contribution. What happens when an aggregate query is > issued on Kylin with ES as the storage engine? > > > > On 1/26/16, 2:53 PM, "LIU Ze (刘则)" <[email protected]> wrote: > > >hi hongbin, > > > >I will try to add to 2.x-staging. > >we use elasticsearch just to query and filter details . > >E.g Filtered user attributes and message them to do promotions : select > >mobile from member_table where sex='1' and grade=2 > >if you use hbase ,Too many phone numbers of different values ,so I add > >elasticsearch. > > > >I also wirite the aggregation of elasticsearch,But run slower ,so I did > >not commit it. > > > >________________________________ > > > >From: hongbin ma<mailto:[email protected]> > >Date: 2016-01-26 14:42 > >To: [email protected]<mailto:[email protected]>; LIU Ze (刘则 > >)<mailto:[email protected]> > >Subject: elastic search as kylin storage engine > >hi liuze > > > >Thanks for contributing kylin-es, I believe it will benefit Kylin users > >in ES world a lot. > > > >I noticed your patch is against master branch (kylin 1.2), we can > >definitely work on merging it to 1.x branch. However our active develop > >branch is now 2.x-staging, maintaing such a big feature in both sides is > >not a wise choice, I guess. What's more, 2.x was refactored to better > >embrace plugins modules like yours. So I'm wondering if you're interested > >in familiarizing yourself with 2.x-staging code and migrate your patch to > >2.x? In the meantime I'll try to review the code (It might take a while > >because I'm not familiar with ES that much) > > > >some helpful links: > > > >http://kylin.apache.org/development/howto_test.html > >http://kylin.apache.org/development/dev_env.html > > > >I also Opened a jira for this task: > >https://issues.apache.org/jira/browse/KYLIN-1371, let's collaborate > >there. > > > > > >-- > >Regards, > > > >Bin Mahone | 马洪宾 > > -- Best regards, Shaofeng Shi
