----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39911/#review106370 -----------------------------------------------------------
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java (line 114) <https://reviews.apache.org/r/39911/#comment165122> hiveHandle variable is tracking one-to-one mapping for QueryHandle with OperationHandle. Tracking QueryHandle is not sufficient? lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java (line 1245) <https://reviews.apache.org/r/39911/#comment165112> In my opinion we shouldn't change the default behavior of this API. Since the user asked to close the session this semantic implies that the underying queries should be killed. If we want to address the usecase of closing the session that are inactive and are not running any queries then driver should have an API to return the running queries for a session. And the caller should make a call whether they want to first check if there are any running queries in the driver before calling closeSession. lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java (line 1258) <https://reviews.apache.org/r/39911/#comment165114> If we indeed decide to change the semantic of this method then we should minimally communicate back to the user that the session was not really closed, mere logging is not sufficient. This will have a cascading impact to the closeSession API exposed to the user. - Pranav Agarwal On Nov. 8, 2015, 6:58 p.m., Deepak Barr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39911/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2015, 6:58 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > OperationHandle-HiveSession mapping is maintained for all active operations. > Now, hive session will only be closed when there are no active operations > running on that session. > > > Diffs > ----- > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > c96ef20 > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > c37b0ed > > Diff: https://reviews.apache.org/r/39911/diff/ > > > Testing > ------- > > Yes. > > 1. Created session. > 2. Fired a query. > 3. Deleted the session before query finishes. > 4. Query keeps running and finishes eventually. > > > Thanks, > > Deepak Barr > >
