> On Nov. 26, 2015, 9:14 a.m., Amareshwari Sriramadasu wrote: > > Deepak Barr, Is there any update on this for review comments?
Sorry, I was occupied with something else. Will resume work on this. From the review comments, I am thinking we should do the following - 1. For sync queries (CLI), closing the session will kill the queries . For async, queries wont be killed. 2. We will clean up the orphaned hive sessions periodically when the queries on the hive session finishes. I imagined hive might clean up the session after certain timeout but the functionaliy is available version 0.14 onwards (HIVE-5799). Let me know if its fine with everyone. - Deepak ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39911/#review108103 ----------------------------------------------------------- On Nov. 8, 2015, 6:58 p.m., Deepak Barr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39911/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2015, 6:58 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > OperationHandle-HiveSession mapping is maintained for all active operations. > Now, hive session will only be closed when there are no active operations > running on that session. > > > Diffs > ----- > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > c96ef20 > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > c37b0ed > > Diff: https://reviews.apache.org/r/39911/diff/ > > > Testing > ------- > > Yes. > > 1. Created session. > 2. Fired a query. > 3. Deleted the session before query finishes. > 4. Query keeps running and finishes eventually. > > > Thanks, > > Deepak Barr > >
