> On Nov. 13, 2015, 6:57 a.m., Pranav Agarwal wrote: > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, > > line 1258 > > <https://reviews.apache.org/r/39911/diff/2/?file=1119315#file1119315line1258> > > > > If we indeed decide to change the semantic of this method then we > > should minimally communicate back to the user that the session was not > > really closed, mere logging is not sufficient. This will have a cascading > > impact to the closeSession API exposed to the user. > > Deepak Barr wrote: > Closing a session will close the lens session but not the underlying hive > session. I dont think it should be ok to tell the user that the session is > closed because session can not be used again anyway. What do you think ? > > Deepak Barr wrote: > correction - I think it should be ok to tell the user that the session > is closed because session can not be used again anyway. What do you think ?
seems fine. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39911/#review106370 ----------------------------------------------------------- On Nov. 8, 2015, 6:58 p.m., Deepak Barr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39911/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2015, 6:58 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > OperationHandle-HiveSession mapping is maintained for all active operations. > Now, hive session will only be closed when there are no active operations > running on that session. > > > Diffs > ----- > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > c96ef20 > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > c37b0ed > > Diff: https://reviews.apache.org/r/39911/diff/ > > > Testing > ------- > > Yes. > > 1. Created session. > 2. Fired a query. > 3. Deleted the session before query finishes. > 4. Query keeps running and finishes eventually. > > > Thanks, > > Deepak Barr > >
