----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40638/#review107770 -----------------------------------------------------------
lens-api/src/main/java/org/apache/lens/api/util/DateUtil.java (line 32) <https://reviews.apache.org/r/40638/#comment167057> We already have a class with this name in lens-cube module. Maybe we can re-think on the name? lens-api/src/main/resources/example-job.xml (line 22) <https://reviews.apache.org/r/40638/#comment167059> Maybe this can be in lens-examples module lens-api/src/main/resources/example-job.xml (line 26) <https://reviews.apache.org/r/40638/#comment167058> remove semicolon. And we should give cube queries in examples. lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java (line 31) <https://reviews.apache.org/r/40638/#comment167061> What are intended usages of this class? I couldn't find any. lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java (line 28) <https://reviews.apache.org/r/40638/#comment167060> see https://projectlombok.org/features/Data.html - Rajat Khandelwal On Nov. 24, 2015, 5:50 p.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40638/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2015, 5:50 p.m.) > > > Review request for lens. > > > Bugs: LENS-879 > https://issues.apache.org/jira/browse/LENS-879 > > > Repository: lens > > > Description > ------- > > Base framework for lens scheduler service and job definition. > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/util/DateUtil.java PRE-CREATION > lens-api/src/main/java/org/apache/lens/api/util/DateValidator.java > PRE-CREATION > lens-api/src/main/resources/example-job.xml PRE-CREATION > lens-api/src/main/resources/job-0.1.xsd PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java > 9f48d27 > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/Scheduler.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java > 3389aba > > lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java > 24949bd > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerService.java > PRE-CREATION > lens-server/src/main/resources/lensserver-default.xml 5f268cb > > lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java > e11413e > pom.xml b19857f > src/site/apt/admin/config.apt 88c1489 > > Diff: https://reviews.apache.org/r/40638/diff/ > > > Testing > ------- > > > Thanks, > > Ajay Yadava > >
