-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review108090
-----------------------------------------------------------



lens-api/src/main/resources/example-job.xml (lines 27 - 35)
<https://reviews.apache.org/r/40638/#comment167469>

    Feels like keeping two conf is only useful when they are present on 
different heirarchies. 
    
    If we are creating session just to run a single query, then there is no 
point of having session level and query level configurations. One configuration 
should be enough
    
    Thinking in those terms, an execution shouldn't be a `query`, it should be 
a session. Inside that session there can be multiple actions, which might 
decide the next actions. Any of those actions can be a `query` action. 
    
    Thoughts?



pom.xml (line 61)
<https://reviews.apache.org/r/40638/#comment167468>

    Can you mention which new feature you are using?
    
    And please verify this version is backward compatible.


- Rajat Khandelwal


On Nov. 25, 2015, 9:27 p.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2015, 9:27 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-879
>     https://issues.apache.org/jira/browse/LENS-879
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Base framework for lens scheduler service and job definition.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java
>  PRE-CREATION 
>   lens-api/src/main/resources/example-job.xml PRE-CREATION 
>   lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION 
>   lens-examples/src/main/resources/example-job.xml PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java
>  9f48d27 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
>  3389aba 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java
>  24949bd 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
>  PRE-CREATION 
>   lens-server/src/main/resources/lensserver-default.xml 5f268cb 
>   
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java
>  e11413e 
>   pom.xml b19857f 
>   src/site/apt/admin/config.apt 88c1489 
> 
> Diff: https://reviews.apache.org/r/40638/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>

Reply via email to