> On Nov. 24, 2015, 1:33 p.m., Rajat Khandelwal wrote: > > lens-api/src/main/resources/example-job.xml, line 26 > > <https://reviews.apache.org/r/40638/diff/1/?file=1138730#file1138730line26> > > > > remove semicolon. And we should give cube queries in examples.
Will fix. > On Nov. 24, 2015, 1:33 p.m., Rajat Khandelwal wrote: > > lens-api/src/main/java/org/apache/lens/api/util/DateUtil.java, line 32 > > <https://reviews.apache.org/r/40638/diff/1/?file=1138728#file1138728line32> > > > > We already have a class with this name in lens-cube module. Maybe we > > can re-think on the name? As long as these are in different packages it should be fine. > On Nov. 24, 2015, 1:33 p.m., Rajat Khandelwal wrote: > > lens-api/src/main/resources/example-job.xml, line 22 > > <https://reviews.apache.org/r/40638/diff/1/?file=1138730#file1138730line22> > > > > Maybe this can be in lens-examples module Will move. > On Nov. 24, 2015, 1:33 p.m., Rajat Khandelwal wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java, > > line 31 > > <https://reviews.apache.org/r/40638/diff/1/?file=1138735#file1138735line31> > > > > What are intended usages of this class? I couldn't find any. This was slightly future looking. Amareshwari has also pointed a use case for the same. > On Nov. 24, 2015, 1:33 p.m., Rajat Khandelwal wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java, > > line 28 > > <https://reviews.apache.org/r/40638/diff/1/?file=1138736#file1138736line28> > > > > see https://projectlombok.org/features/Data.html Will fix. - Ajay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40638/#review107770 ----------------------------------------------------------- On Nov. 24, 2015, 12:20 p.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40638/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2015, 12:20 p.m.) > > > Review request for lens. > > > Bugs: LENS-879 > https://issues.apache.org/jira/browse/LENS-879 > > > Repository: lens > > > Description > ------- > > Base framework for lens scheduler service and job definition. > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/util/DateUtil.java PRE-CREATION > lens-api/src/main/java/org/apache/lens/api/util/DateValidator.java > PRE-CREATION > lens-api/src/main/resources/example-job.xml PRE-CREATION > lens-api/src/main/resources/job-0.1.xsd PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java > 9f48d27 > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/Scheduler.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java > 3389aba > > lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java > 24949bd > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerService.java > PRE-CREATION > lens-server/src/main/resources/lensserver-default.xml 5f268cb > > lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java > e11413e > pom.xml b19857f > src/site/apt/admin/config.apt 88c1489 > > Diff: https://reviews.apache.org/r/40638/diff/ > > > Testing > ------- > > > Thanks, > > Ajay Yadava > >
