> On Nov. 27, 2015, 5:25 a.m., Amareshwari Sriramadasu wrote: > > lens-api/src/main/resources/example-job.xml, line 1 > > <https://reviews.apache.org/r/40638/diff/2/?file=1147004#file1147004line1> > > > > Seems forgot to remove the class from lens-api.
Oops. Will remove it. > On Nov. 27, 2015, 5:25 a.m., Amareshwari Sriramadasu wrote: > > lens-examples/src/main/resources/example-job.xml, line 31 > > <https://reviews.apache.org/r/40638/diff/2/?file=1147006#file1147006line31> > > > > session_db here is the db name : like default or db1 or mydb or any I see, will change. Thanks. > On Nov. 27, 2015, 5:25 a.m., Amareshwari Sriramadasu wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java, > > line 29 > > <https://reviews.apache.org/r/40638/diff/2/?file=1147009#file1147009line29> > > > > Is this the class returned to client. It should be moved to lens-api > > module Yes, that's the intention. will move. > On Nov. 27, 2015, 5:25 a.m., Amareshwari Sriramadasu wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java, > > line 27 > > <https://reviews.apache.org/r/40638/diff/2/?file=1147010#file1147010line27> > > > > move to lens-api module Will move. > On Nov. 27, 2015, 5:25 a.m., Amareshwari Sriramadasu wrote: > > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java, > > line 42 > > <https://reviews.apache.org/r/40638/diff/2/?file=1147002#file1147002line42> > > > > I feel we should call the class ScheduleHandle instead of > > SchedulerJobHandler. > > > > and similarly others. what do you think? Do you mean to use Schedule instead of SchedulerJob everywhere? I had given my reasons above for not incorporating those changes earlier. If it still looks out of place to you then I am happy to change it. Just let me know what would you like for the following: SchdulerJob -> ? SchedulerJobInstance -> ? - Ajay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40638/#review108188 ----------------------------------------------------------- On Nov. 25, 2015, 3:57 p.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40638/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2015, 3:57 p.m.) > > > Review request for lens. > > > Bugs: LENS-879 > https://issues.apache.org/jira/browse/LENS-879 > > > Repository: lens > > > Description > ------- > > Base framework for lens scheduler service and job definition. > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java > PRE-CREATION > > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java > PRE-CREATION > lens-api/src/main/resources/example-job.xml PRE-CREATION > lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION > lens-examples/src/main/resources/example-job.xml PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java > 9f48d27 > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java > 3389aba > > lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java > 24949bd > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java > PRE-CREATION > lens-server/src/main/resources/lensserver-default.xml 5f268cb > > lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java > e11413e > pom.xml b19857f > src/site/apt/admin/config.apt 88c1489 > > Diff: https://reviews.apache.org/r/40638/diff/ > > > Testing > ------- > > > Thanks, > > Ajay Yadava > >
