----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40638/#review108280 -----------------------------------------------------------
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java (line 38) <https://reviews.apache.org/r/40638/#comment167633> Is this not ScheduleJobHandle ? lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java (lines 47 - 87) <https://reviews.apache.org/r/40638/#comment167650> I think all of these fields should be replaced with single object XJob lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java (line 55) <https://reviews.apache.org/r/40638/#comment167634> we should return XJob instead of Clob. lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java (line 63) <https://reviews.apache.org/r/40638/#comment167635> Instead of Clob we should return correspondig objects. Applies for all Clob objects. lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java (line 33) <https://reviews.apache.org/r/40638/#comment167636> Should be SchedulerJobInstanceHandle lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java (line 36) <https://reviews.apache.org/r/40638/#comment167638> Why is this new session handle. Should be "session handle in which instance was run" lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java (line 39) <https://reviews.apache.org/r/40638/#comment167639> Return LensSessionHandle ? lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java (line 42) <https://reviews.apache.org/r/40638/#comment167640> StartTime - when the instance started to run. I see all other comments are also saying the values to be set. Instead they are actually when it ran. lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java (line 81) <https://reviews.apache.org/r/40638/#comment167641> I dont think we would allow modification of an instance, so should not be required. lens-api/src/main/resources/scheduler-job-0.1.xsd (line 47) <https://reviews.apache.org/r/40638/#comment167642> Should be "Name of the scheduled job" ? lens-api/src/main/resources/scheduler-job-0.1.xsd (line 102) <https://reviews.apache.org/r/40638/#comment167643> If we are separating session into separate type, resource_path should be actually part of session. lens-api/src/main/resources/scheduler-job-0.1.xsd (line 117) <https://reviews.apache.org/r/40638/#comment167644> Can we be consistent with names for types and elements? All types can start with x_type and elements would contain actual names and no x_ ? lens-api/src/main/resources/scheduler-job-0.1.xsd (line 122) <https://reviews.apache.org/r/40638/#comment167646> Can you change the comment to "Database name to be used in session" ? lens-api/src/main/resources/scheduler-job-0.1.xsd (line 153) <https://reviews.apache.org/r/40638/#comment167647> Comment needs to be updated. lens-examples/src/main/resources/example-job.xml (line 1) <https://reviews.apache.org/r/40638/#comment167649> Can we update the client packaging to include schedule-examples/ ? - Amareshwari Sriramadasu On Nov. 27, 2015, 7:46 p.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40638/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2015, 7:46 p.m.) > > > Review request for lens. > > > Bugs: LENS-879 > https://issues.apache.org/jira/browse/LENS-879 > > > Repository: lens > > > Description > ------- > > Base framework for lens scheduler service and job definition. > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java > PRE-CREATION > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java > PRE-CREATION > > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java > PRE-CREATION > > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java > PRE-CREATION > lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION > lens-examples/src/main/resources/example-job.xml PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java > 9f48d27 > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobStats.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java > 3389aba > > lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java > 24949bd > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java > PRE-CREATION > lens-server/src/main/resources/lensserver-default.xml 5f268cb > > lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java > e11413e > pom.xml b19857f > src/site/apt/admin/config.apt 88c1489 > > Diff: https://reviews.apache.org/r/40638/diff/ > > > Testing > ------- > > > Thanks, > > Ajay Yadava > >
