> On Nov. 27, 2015, 11 a.m., Rajat Khandelwal wrote: > > lens-api/src/main/resources/example-job.xml, line 46 > > <https://reviews.apache.org/r/40638/diff/2/?file=1147004#file1147004line46> > > > > I feel like `resource_path` should be part of `execution`. Since it's a > > session's property. Across two different sessions spaced in a long enough > > time frame, adding same resource might end up in addition of different jars.
+1. Should be part of execution. But it will be added once in each schedule's session. > On Nov. 27, 2015, 11 a.m., Rajat Khandelwal wrote: > > lens-api/src/main/resources/scheduler-job-0.1.xsd, line 48 > > <https://reviews.apache.org/r/40638/diff/2/?file=1147005#file1147005line48> > > > > What will job_conf contain? I think it should be configuration for the schedule itself. For example: for specifying number of retries and etc. @ajay, please add documentaion for elements also :) - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40638/#review108207 ----------------------------------------------------------- On Nov. 25, 2015, 3:57 p.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40638/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2015, 3:57 p.m.) > > > Review request for lens. > > > Bugs: LENS-879 > https://issues.apache.org/jira/browse/LENS-879 > > > Repository: lens > > > Description > ------- > > Base framework for lens scheduler service and job definition. > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java > PRE-CREATION > > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java > PRE-CREATION > lens-api/src/main/resources/example-job.xml PRE-CREATION > lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION > lens-examples/src/main/resources/example-job.xml PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java > 9f48d27 > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java > 3389aba > > lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java > 24949bd > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java > PRE-CREATION > lens-server/src/main/resources/lensserver-default.xml 5f268cb > > lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java > e11413e > pom.xml b19857f > src/site/apt/admin/config.apt 88c1489 > > Diff: https://reviews.apache.org/r/40638/diff/ > > > Testing > ------- > > > Thanks, > > Ajay Yadava > >
