----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40638/#review109690 -----------------------------------------------------------
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java (line 34) <https://reviews.apache.org/r/40638/#comment169297> Shouldnt we add its corresponding scheduleJobHandle also ? lens-api/src/main/resources/scheduler-job-0.1.xsd (lines 102 - 106) <https://reviews.apache.org/r/40638/#comment169295> Please add comments for these also. lens-api/src/main/resources/scheduler-job-0.1.xsd (line 153) <https://reviews.apache.org/r/40638/#comment169296> Needs update lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java (line 47) <https://reviews.apache.org/r/40638/#comment169299> return object should be SchedulerJobHandle for all three methods below. lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java (line 57) <https://reviews.apache.org/r/40638/#comment169298> Shouldnt this take SchedulerJobHandle as the param? lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java (line 93) <https://reviews.apache.org/r/40638/#comment169301> Please update the comment with "updates will be applied only for newer instances. Running instances will be running with old definition" lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java (line 192) <https://reviews.apache.org/r/40638/#comment169302> Should there be api to kill/stop running instance ? - Amareshwari Sriramadasu On Dec. 8, 2015, 2:06 p.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40638/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2015, 2:06 p.m.) > > > Review request for lens. > > > Bugs: LENS-879 > https://issues.apache.org/jira/browse/LENS-879 > > > Repository: lens > > > Description > ------- > > Base framework for lens scheduler service and job definition. > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java > PRE-CREATION > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java > PRE-CREATION > > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java > PRE-CREATION > > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java > PRE-CREATION > lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION > lens-examples/src/main/resources/example-job.xml PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java > 9f48d27 > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobStats.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java > 3389aba > > lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java > 24949bd > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java > PRE-CREATION > lens-server/src/main/resources/lensserver-default.xml 39b72dc > > lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java > e11413e > pom.xml 732b3bb > src/site/apt/admin/config.apt bcf4b7d > > Diff: https://reviews.apache.org/r/40638/diff/ > > > Testing > ------- > > > Thanks, > > Ajay Yadava > >
