----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39911/#review109927 -----------------------------------------------------------
Deepak, can you mark the review issues as fixed/dropped accordingly ? lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java (line 1284) <https://reviews.apache.org/r/39911/#comment169646> Should we not persist opHandleToSessionHandle map as well? Otherwise, orphaned sessions will be still orphaned upon lens server restart. - Amareshwari Sriramadasu On Dec. 10, 2015, 10:19 a.m., Deepak Barr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39911/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2015, 10:19 a.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > OperationHandle-HiveSession mapping is maintained for all active operations. > Now, hive session will only be closed when there are no active operations > running on that session. > > > Diffs > ----- > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > a84c679 > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java > ab5ada9 > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > f6693aa > > Diff: https://reviews.apache.org/r/39911/diff/ > > > Testing > ------- > > Yes. > > 1. Created session. > 2. Fired a query. > 3. Deleted the session before query finishes. > 4. Query keeps running and finishes eventually. > > > Thanks, > > Deepak Barr > >
