> On Dec. 10, 2015, 4:41 a.m., Puneet Gupta wrote: > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, > > line 535 > > <https://reviews.apache.org/r/39911/diff/3/?file=1150389#file1150389line535> > > > > If closeQuery() is not called before this, which happens for (result == > > null || !(result instanceof HiveInMemoryResultSet), how will the oprphan > > session be closed? > > As of now closeQuery() is doing that also.
Looking at the execute method and its comment[assuming this is only called for executing explain/insert/set/delete/etc... queries which don't ask to fetch data.),I think this method is only called for queries that do not return result,so I assumed closeQuery() will be called.Looking at the code, I can see this method is called for "add jar" and "explain" queries. - Deepak ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39911/#review109474 ----------------------------------------------------------- On Dec. 2, 2015, 10:40 a.m., Deepak Barr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39911/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2015, 10:40 a.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > OperationHandle-HiveSession mapping is maintained for all active operations. > Now, hive session will only be closed when there are no active operations > running on that session. > > > Diffs > ----- > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > a84c679 > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java > ab5ada9 > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > f6693aa > > Diff: https://reviews.apache.org/r/39911/diff/ > > > Testing > ------- > > Yes. > > 1. Created session. > 2. Fired a query. > 3. Deleted the session before query finishes. > 4. Query keeps running and finishes eventually. > > > Thanks, > > Deepak Barr > >
