----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42070/#review117195 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java (line 131) <https://reviews.apache.org/r/42070/#comment178309> Seems it should be equal instead of contains. Also, please check if ASTNode.equals is better than converting to string. lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java (line 176) <https://reviews.apache.org/r/42070/#comment178315> Check if this can happen. lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java (line 582) <https://reviews.apache.org/r/42070/#comment178316> Add test with only one having clause - Amareshwari Sriramadasu On Jan. 27, 2016, 7:51 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42070/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2016, 7:51 a.m.) > > > Review request for lens. > > > Bugs: LENS-813 > https://issues.apache.org/jira/browse/LENS-813 > > > Repository: lens > > > Description > ------- > > > Diffs > ----- > > lens-api/src/main/resources/lens-errors.conf > 9087fcd09f67c462c68f5385a58360bb8a16374b > lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java > 61d08b2769deb554eb3dc2d992b7a6b8ba3484b8 > lens-cube/src/main/java/org/apache/lens/cube/parse/AliasDecider.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java > c305244c98ff38a0acaa24812ccec9d2910e0095 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > 79dd88c8d2f94b0bb2a9c12fe3ccc3e39e655972 > lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultAliasDecider.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java > 5ff265db155363938f3b657256bb232056e50f78 > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java > b1deb0753fe36d2908ed4c8a98178a93644fab64 > lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java > 1a729f8eab5cb3f8ab2eeb9bf32dc0c3efc05620 > > lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java > 7e3a0bfa703d27f38c5b2a5935d7d2da07125b7c > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java > 57a15e23a39cf09e1f167740083b43bb154334eb > > Diff: https://reviews.apache.org/r/42070/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
