> On Jan. 27, 2016, 10:30 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java, line > > 128 > > <https://reviews.apache.org/r/42070/diff/3/?file=1221272#file1221272line128> > > > > Can you explain whats happening here? > > > > HQLParser.getString() is a costly operation on AST, should be called > > sparingly.
Trying to figure out whether the ast is in the select tree or not. So two trees have to be traversed and compared. Comparing strings allows me to compare the traversal outputs. > On Jan. 27, 2016, 10:30 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java, line > > 186 > > <https://reviews.apache.org/r/42070/diff/3/?file=1221272#file1221272line186> > > > > Why is it catching LensException ? Removed. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42070/#review116536 ----------------------------------------------------------- On Jan. 26, 2016, 12:20 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42070/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2016, 12:20 p.m.) > > > Review request for lens. > > > Bugs: LENS-813 > https://issues.apache.org/jira/browse/LENS-813 > > > Repository: lens > > > Description > ------- > > > Diffs > ----- > > lens-api/src/main/resources/lens-errors.conf > 9087fcd09f67c462c68f5385a58360bb8a16374b > lens-client/src/main/java/org/apache/lens/client/LensClient.java > f7f99c7c20b97e9f2b53c39ee147d5cc682f93dc > lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java > 61d08b2769deb554eb3dc2d992b7a6b8ba3484b8 > lens-cube/src/main/java/org/apache/lens/cube/parse/AliasDecider.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java > c305244c98ff38a0acaa24812ccec9d2910e0095 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > 79dd88c8d2f94b0bb2a9c12fe3ccc3e39e655972 > lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultAliasDecider.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java > 5ff265db155363938f3b657256bb232056e50f78 > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java > b1deb0753fe36d2908ed4c8a98178a93644fab64 > lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java > 1a729f8eab5cb3f8ab2eeb9bf32dc0c3efc05620 > > lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java > 7e3a0bfa703d27f38c5b2a5935d7d2da07125b7c > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 100d7c9cceb5feb98c5e88a688e364298d6543be > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java > 57a15e23a39cf09e1f167740083b43bb154334eb > > Diff: https://reviews.apache.org/r/42070/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
