> On Jan. 11, 2016, 10:01 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java, > > lines 191-198 > > <https://reviews.apache.org/r/42070/diff/1/?file=1187458#file1187458line191> > > > > Why is additional loop required? > > Rajat Khandelwal wrote: > Fact's select tree has original query's select tree and extra select > expressisons picked from having expression. The first loop is over select > expressions 0 to `cubeql.getselecttree.getchildcount`. This loop is over the > extra columns picked from having. > > Amareshwari Sriramadasu wrote: > Reopening this, as I dont see why this loop is required just after the > loop above.
Removed now. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42070/#review113673 ----------------------------------------------------------- On Feb. 1, 2016, 6:12 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42070/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2016, 6:12 p.m.) > > > Review request for lens. > > > Bugs: LENS-813 > https://issues.apache.org/jira/browse/LENS-813 > > > Repository: lens > > > Description > ------- > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java > 61d08b2769deb554eb3dc2d992b7a6b8ba3484b8 > lens-cube/src/main/java/org/apache/lens/cube/parse/AliasDecider.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java > c305244c98ff38a0acaa24812ccec9d2910e0095 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > 79dd88c8d2f94b0bb2a9c12fe3ccc3e39e655972 > lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultAliasDecider.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java > 5ff265db155363938f3b657256bb232056e50f78 > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java > c9aff5da2566e6a2c96e0e0592a533e5e504888a > lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java > 1a729f8eab5cb3f8ab2eeb9bf32dc0c3efc05620 > > lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java > 7e3a0bfa703d27f38c5b2a5935d7d2da07125b7c > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java > 57a15e23a39cf09e1f167740083b43bb154334eb > > Diff: https://reviews.apache.org/r/42070/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
