> On March 8, 2016, 11:42 a.m., Raju Bairishetti wrote: > > lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java, > > line 84 > > <https://reviews.apache.org/r/44436/diff/1/?file=1282192#file1282192line84> > > > > Do we need to **alter the table with new column** in case of > > finished_queries exists?
I think this scenario is not been handled for any additions/alterations until now . As of now for existing setups, we are manually altering the table. We can create a new JIRA to handle all alter cases. There we can run a set of alter scripts (but it can be more complex if we allow upgrade from any old version to any new version). - Puneet ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44436/#review122501 ----------------------------------------------------------- On March 7, 2016, 4:30 a.m., Puneet Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44436/ > ----------------------------------------------------------- > > (Updated March 7, 2016, 4:30 a.m.) > > > Review request for lens. > > > Bugs: lens-919 > https://issues.apache.org/jira/browse/lens-919 > > > Repository: lens > > > Description > ------- > > As of now Query Priority is not persisted. The query details API shows query > priority only until query is in memory. Once purged this info is not > available . > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java > a57a6e4ed1827ee5094cbfd423c183766d9dc5f4 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java > 96846c1b89b47a971916ab230bb7f4691d52b524 > lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java > d8e654d72989d7a8f9334adc81b82a9e0810ee39 > lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java > 760e306ddef9baec65ee43e3880c9433791259dc > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > 699fa686f5feb865b029b4024e049520a22840da > > Diff: https://reviews.apache.org/r/44436/diff/ > > > Testing > ------- > > updated test cases to check for query priority and tested them > > > ------------------------------------------------------- > T E S T S > ------------------------------------------------------- > Running org.apache.lens.server.query.TestQueryService > Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 63.063 sec - > in org.apache.lens.server.query.TestQueryService > > Results : > > Tests run: 2, Failures: 0, Errors: 0, Skipped: 0 > > > Thanks, > > Puneet Gupta > >
