> On March 14, 2016, 9:52 a.m., Rajat Khandelwal wrote: > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java, > > lines 320-325 > > <https://reviews.apache.org/r/44436/diff/1/?file=1282194#file1282194line320> > > > > Should this test belong to `TestLensServerDAO`? reading a query from db > > and checking whether or not it has priority.
The other test metioned by you is already added to TestLensDAO. Here I wanted to do an end to end check. In both cases an existing test case has been updated > On March 14, 2016, 9:52 a.m., Rajat Khandelwal wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java, > > lines 173-176 > > <https://reviews.apache.org/r/44436/diff/1/?file=1282190#file1282190line173> > > > > Can't this be `Priority` instead of `String`? > > > > Not sure, but I probably enum fields might have direct handling from db. I am not sure. We may be able to add some handlers, but it will be stored as string in DB. Same handling is done for Status enum. Its stored as string - Puneet ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44436/#review123393 ----------------------------------------------------------- On March 7, 2016, 4:30 a.m., Puneet Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44436/ > ----------------------------------------------------------- > > (Updated March 7, 2016, 4:30 a.m.) > > > Review request for lens. > > > Bugs: lens-919 > https://issues.apache.org/jira/browse/lens-919 > > > Repository: lens > > > Description > ------- > > As of now Query Priority is not persisted. The query details API shows query > priority only until query is in memory. Once purged this info is not > available . > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java > a57a6e4ed1827ee5094cbfd423c183766d9dc5f4 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java > 96846c1b89b47a971916ab230bb7f4691d52b524 > lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java > d8e654d72989d7a8f9334adc81b82a9e0810ee39 > lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java > 760e306ddef9baec65ee43e3880c9433791259dc > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > 699fa686f5feb865b029b4024e049520a22840da > > Diff: https://reviews.apache.org/r/44436/diff/ > > > Testing > ------- > > updated test cases to check for query priority and tested them > > > ------------------------------------------------------- > T E S T S > ------------------------------------------------------- > Running org.apache.lens.server.query.TestQueryService > Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 63.063 sec - > in org.apache.lens.server.query.TestQueryService > > Results : > > Tests run: 2, Failures: 0, Errors: 0, Skipped: 0 > > > Thanks, > > Puneet Gupta > >
