----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44436/#review123855 -----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1770) <https://reviews.apache.org/r/44436/#comment186140> Can we push the call to decidePriority to rewriteAndSelect itself ? lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 2004) <https://reviews.apache.org/r/44436/#comment186139> This is happening after launch, which seems wrong. - Amareshwari Sriramadasu On March 15, 2016, 2:45 a.m., Puneet Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44436/ > ----------------------------------------------------------- > > (Updated March 15, 2016, 2:45 a.m.) > > > Review request for lens. > > > Bugs: lens-919 > https://issues.apache.org/jira/browse/lens-919 > > > Repository: lens > > > Description > ------- > > As of now Query Priority is not persisted. The query details API shows query > priority only until query is in memory. Once purged this info is not > available . > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java > d447417 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java > a57a6e4 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java > 96846c1 > lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java > d8e654d > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 49ab241 > lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java > 760e306 > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > 699fa68 > > Diff: https://reviews.apache.org/r/44436/diff/ > > > Testing > ------- > > updated test cases to check for query priority and tested them > > > ------------------------------------------------------- > T E S T S > ------------------------------------------------------- > Running org.apache.lens.server.query.TestQueryService > Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 63.063 sec - > in org.apache.lens.server.query.TestQueryService > > Results : > > Tests run: 2, Failures: 0, Errors: 0, Skipped: 0 > > > Thanks, > > Puneet Gupta > >
