> On May 5, 2016, 12:14 p.m., Puneet Gupta wrote: > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, > > line 1797 > > <https://reviews.apache.org/r/47007/diff/1/?file=1372924#file1372924line1797> > > > > Some more things that we need to decide on > > > > 1. What do we do if the partition for a query is re-registered /dropped > > > > 2. Data changes on stoarge will not be handled > > > > 3. Session conf may also get updated between requests. How do we handle > > that
User can cancel earlier queued or running query, before submitting again, in all the above cases - If it is a genuine resubmission. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47007/#review131812 ----------------------------------------------------------- On May 5, 2016, 10:26 a.m., Lavkesh Lahngir wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47007/ > ----------------------------------------------------------- > > (Updated May 5, 2016, 10:26 a.m.) > > > Review request for lens. > > > Bugs: LENS-1019 > https://issues.apache.org/jira/browse/LENS-1019 > > > Repository: lens > > > Description > ------- > > If query is repeated from user - with same query, same name, same conf on the > same session > and earlier is still queued or running, then return the same handle. This > will only handle the case of aysnc queries. > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/LensConf.java 86504c7 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 42bd4ab > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > df13ba2 > > Diff: https://reviews.apache.org/r/47007/diff/ > > > Testing > ------- > > testExecuteAsyncDuplicate() methods tests the following. > 1. Same query, same user and same session returns the same handle. > 2. After query completion, same query firing will give the different handle. > 3. Differnt session and same query will return different handle. > > > Thanks, > > Lavkesh Lahngir > >
