----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47007/#review132255 -----------------------------------------------------------
lens-api/pom.xml (line 38) <https://reviews.apache.org/r/47007/#comment196450> why are we putting hadoop-client dependency on lens-api ? lens-api will be client facing and it should not bring hadoop-client dependency here. lens-api/src/main/java/org/apache/lens/api/util/CommonUtils.java (line 98) <https://reviews.apache.org/r/47007/#comment196451> Lets move the utils to LensUtil in lens-server-api lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1796) <https://reviews.apache.org/r/47007/#comment196453> Shall we have the feature enable or disable at server side? - Amareshwari Sriramadasu On May 9, 2016, 11:59 a.m., Lavkesh Lahngir wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47007/ > ----------------------------------------------------------- > > (Updated May 9, 2016, 11:59 a.m.) > > > Review request for lens. > > > Bugs: LENS-1019 > https://issues.apache.org/jira/browse/LENS-1019 > > > Repository: lens > > > Description > ------- > > If query is repeated from user - with same query, same name, same conf on the > same session > and earlier is still queued or running, then return the same handle. This > will only handle the case of aysnc queries. > > > Diffs > ----- > > lens-api/pom.xml 9b5e5f8 > lens-api/src/main/java/org/apache/lens/api/util/CommonUtils.java 119c924 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java > 94b79d0 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 42bd4ab > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > df13ba2 > > Diff: https://reviews.apache.org/r/47007/diff/ > > > Testing > ------- > > testExecuteAsyncDuplicate() methods tests the following. > 1. Same query, same user and same session returns the same handle. > 2. After query completion, same query firing will give the different handle. > 3. Differnt session and same query will return different handle. > > > Thanks, > > Lavkesh Lahngir > >
