-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47007/
-----------------------------------------------------------

(Updated May 9, 2016, 9:41 a.m.)


Review request for lens.


Changes
-------

Review comments. Checking the query name, storing the hash of the lensconf.


Bugs: LENS-1019
    https://issues.apache.org/jira/browse/LENS-1019


Repository: lens


Description
-------

If query is repeated from user - with same query, same name, same conf on the 
same session
and earlier is still queued or running, then return the same handle. This will 
only handle the case of aysnc queries.


Diffs (updated)
-----

  lens-api/src/main/java/org/apache/lens/api/LensConf.java 86504c7 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
 94b79d0 
  
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 42bd4ab 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
df13ba2 

Diff: https://reviews.apache.org/r/47007/diff/


Testing
-------

testExecuteAsyncDuplicate() methods tests the following.
1. Same query, same user and same session returns the same handle.
2. After query completion, same query firing will give the different handle.
3. Differnt session and same query will return different handle.


Thanks,

Lavkesh Lahngir

Reply via email to