----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48842/#review138189 -----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java (line 119) <https://reviews.apache.org/r/48842/#comment203407> Passing joda.time.DateTime over REST can cause errors. lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java (line 52) <https://reviews.apache.org/r/48842/#comment203410> Can we use validateSession in BaseLensService? lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java (line 67) <https://reviews.apache.org/r/48842/#comment203412> Seems we are creating too many resources by appending operation to resource path. Lets have resources and their operations as the following : jobs/ - POST : Create new job and return a jobHandle - GET : List all jobs, Queryparams will take filters - DELETE : Delete jobs. jobs/{jobHandle} - GET : Get the definition - DELETE : Delete the scheduled job - PUT : Update schedule definition. jobs/{jobHandle}/details - GET : Get the details of job. jobs/{jobHandle}/state - GET : Get schedule state (When created will in state NEW) : Possible values NEW, SCHEDULED, SUSPENDED, EXPIRED - PUT : query param as Schedule/Suspend/Resume : Calling schedule/suspend/resume again and again will be a no-op. - DELETE : Expire the schedule jobs/{jobHandle}/instances - GET : List all instances jobs/{jobHandle}/instances/{instanceHandle} - GET Get details of an instance - POST Rerun an instance - DELETE cancel an instance lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java (line 274) <https://reviews.apache.org/r/48842/#comment203413> Do not catch and throw exception as WebApplicationException. We already have ExceptionMapper for LensException and will be handled. - Amareshwari Sriramadasu On June 17, 2016, 8:45 a.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48842/ > ----------------------------------------------------------- > > (Updated June 17, 2016, 8:45 a.m.) > > > Review request for lens. > > > Bugs: LENS-1184 > https://issues.apache.org/jira/browse/LENS-1184 > > > Repository: lens > > > Description > ------- > > This patch adds REST API signatures and some other skeleton classes for > Scheduler. > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java > b6ec093 > > lens-server/src/main/java/org/apache/lens/server/scheduler/LensScheduler.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java > abc4621 > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java > ce98601 > > lens-server/src/main/java/org/apache/lens/server/scheduler/store/SchedulerDAO.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/48842/diff/ > > > Testing > ------- > > > Thanks, > > Ajay Yadava > >
