-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48842/#review140108
-----------------------------------------------------------




lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java
 (line 79)
<https://reviews.apache.org/r/48842/#comment205408>

    lets make action as optional param, by passing default value.



lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java
 (lines 93 - 97)
<https://reviews.apache.org/r/48842/#comment205409>

    Lets make all these params optional, by passing default values. You can 
have a look at QueryServiceResource.getAllQueries


- Amareshwari Sriramadasu


On June 29, 2016, 2:51 p.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48842/
> -----------------------------------------------------------
> 
> (Updated June 29, 2016, 2:51 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1184
>     https://issues.apache.org/jira/browse/LENS-1184
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> This patch adds REST API signatures and some other skeleton classes for 
> Scheduler.
> 
> scheduler/
> 
> jobs - POST - submits a new job.
> 
> jobs/stats - GET - get stats for all jobs
> 
> jobs/{jobHandle} - GET - get job definition
>                  - DELETE - Delete job 
>                  - POST - (based on query parameter it will - schedule / 
> expire / suspend / resume a job.
>                 
> 
> jobs/{jobHandle}/stats - GET - get stats for a particular job.
> 
> jobs/{jobHandle}/instances - GET - get all instances for a given job.
> 
> instances/{instanceHandle}/ - GET - get details for a given instance.
>                             - POST - based upon "action" query parameter - 
> Kill or rerurn an instance
> 
> 
> Diffs
> -----
> 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
>  700a255 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/LensScheduler.java 
> PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java
>  abc4621 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
>  706d54a 
> 
> Diff: https://reviews.apache.org/r/48842/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>

Reply via email to