-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48842/#review138200
-----------------------------------------------------------




lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java
 (line 65)
<https://reviews.apache.org/r/48842/#comment203418>

    If sessionId is going as query param, input need not be multipart-form. 
Could be simple xml or json.



lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java
 (line 78)
<https://reviews.apache.org/r/48842/#comment203417>

    Lets produce json and xml for all api. Can be annotated at class level.



lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java
 (line 132)
<https://reviews.apache.org/r/48842/#comment203419>

    Requires @consumes annotation and we need to consume both xml or json


- Amareshwari Sriramadasu


On June 17, 2016, 8:45 a.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48842/
> -----------------------------------------------------------
> 
> (Updated June 17, 2016, 8:45 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1184
>     https://issues.apache.org/jira/browse/LENS-1184
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> This patch adds REST API signatures and some other skeleton classes for 
> Scheduler.
> 
> 
> Diffs
> -----
> 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
>  b6ec093 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/LensScheduler.java 
> PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java
>  abc4621 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
>  ce98601 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/store/SchedulerDAO.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/48842/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>

Reply via email to