----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53059/#review153865 -----------------------------------------------------------
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestDruidSQLRewriter.java (lines 217 - 269) <https://reviews.apache.org/r/53059/#comment223397> Lot of code duplication here, let's try to use dataprovider lens-driver-jdbc/src/test/resources/drivers/jdbc/druid/jdbcdriver-site.xml (lines 62 - 68) <https://reviews.apache.org/r/53059/#comment223396> Let's not override for all test cases. We can override for individual tests via code. lens-driver-jdbc/src/test/resources/drivers/jdbc/druid/jdbcdriver-site.xml (lines 71 - 81) <https://reviews.apache.org/r/53059/#comment223398> Again, Let's keep using the defaults, override only in selective test cases. - Rajat Khandelwal On Oct. 26, 2016, 4:15 p.m., Rajitha R wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53059/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2016, 4:15 p.m.) > > > Review request for lens and Rajat Khandelwal. > > > Bugs: LENS-1350 > https://issues.apache.org/jira/browse/LENS-1350 > > > Repository: lens > > > Description > ------- > > Fix for bug : Lens-1350 > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java > 355a1f0 > > lens-cube/src/main/java/org/apache/lens/cube/parse/BetweenTimeRangeWriter.java > 046149b > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java > f20f105 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBetweenTimeRangeWriter.java > 07852a0 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java > 3417031 > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DruidSQLRewriter.java > eb1d69c > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java > 82e0231 > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java > f4e0451 > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestDruidSQLRewriter.java > c4cc91d > lens-driver-jdbc/src/test/resources/drivers/jdbc/druid/jdbcdriver-site.xml > e4fad23 > > Diff: https://reviews.apache.org/r/53059/diff/ > > > Testing > ------- > > > Thanks, > > Rajitha R > >
