----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53059/#review154875 -----------------------------------------------------------
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBetweenTimeRangeWriter.java (lines 133 - 152) <https://reviews.apache.org/r/53059/#comment224662> This test confused me untill I downloaded the patch and ran it myself. There are a few things which are not obvious from reading the code, but are obvious when running it. The following suggestions are regarding the same: 1. the set answeringParts doesn't depend on arguments, extract it out. Construct once on class level and use in the testcase. 2. the two integer arguments can be inferred from the two String arguments. I got confused because from the data provider it seemed there are four degrees of freedom in the test case, whereas really there are only two. ``` testStartOffset = START_DATE_OFFSET; testEndOffset = END_DATE_OFFSET; if (startBoundType.equals("OPEN")) testStartOffset -= 1; if (endBoundType.equals("CLOSED")) testEndOffset+=1; ``` - Rajat Khandelwal On Nov. 3, 2016, 2:42 p.m., Rajitha R wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53059/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2016, 2:42 p.m.) > > > Review request for lens and Rajat Khandelwal. > > > Bugs: LENS-1350 > https://issues.apache.org/jira/browse/LENS-1350 > > > Repository: lens > > > Description > ------- > > Fix for bug : Lens-1350 > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java > 355a1f0 > > lens-cube/src/main/java/org/apache/lens/cube/parse/BetweenTimeRangeWriter.java > 046149b > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java > f20f105 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBetweenTimeRangeWriter.java > 07852a0 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java > 3417031 > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DruidSQLRewriter.java > eb1d69c > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java > 7ce1a97 > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java > f4e0451 > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestDruidSQLRewriter.java > c4cc91d > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java > 6291021 > lens-driver-jdbc/src/test/resources/drivers/jdbc/druid/jdbcdriver-site.xml > e4fad23 > src/site/apt/user/cli.apt cf9657a > > Diff: https://reviews.apache.org/r/53059/diff/ > > > Testing > ------- > > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.586s] > [INFO] Lens .............................................. SUCCESS [3.603s] > [INFO] Lens API .......................................... SUCCESS [21.479s] > [INFO] Lens API for server and extensions ................ SUCCESS [19.605s] > [INFO] Lens Cube ......................................... SUCCESS > [14:17.226s] > [INFO] Lens DB storage ................................... SUCCESS [16.911s] > [INFO] Lens Query Library ................................ SUCCESS [13.101s] > [INFO] Lens Hive Driver .................................. SUCCESS [1:14.822s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [45.685s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [21.102s] > [INFO] Lens Server ....................................... SUCCESS > [16:29.198s] > [INFO] Lens client ....................................... SUCCESS [1:24.027s] > [INFO] Lens CLI .......................................... SUCCESS [1:12.692s] > [INFO] Lens Examples ..................................... SUCCESS [8.230s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.605s] > [INFO] Lens Distribution ................................. SUCCESS [8.885s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:01.900s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.030s] > [INFO] Lens Regression ................................... SUCCESS [13.256s] > [INFO] Lens UI ........................................... SUCCESS [31.676s] > [INFO] Lens Contrib ...................................... SUCCESS [0.406s] > [INFO] Lens Contributed Clients .......................... SUCCESS [0.398s] > [INFO] Lens Python Client ................................ SUCCESS [0.437s] > > > Thanks, > > Rajitha R > >
