> On Feb. 21, 2017, 7:11 a.m., Puneet Gupta wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java, > > line 156 > > <https://reviews.apache.org/r/56858/diff/1/?file=1640583#file1640583line156> > > > > Removed ?
This is being calculated unnecessary. - Lavkesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56858/#review166126 ----------------------------------------------------------- On Feb. 21, 2017, 10:10 a.m., Lavkesh Lahngir wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56858/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2017, 10:10 a.m.) > > > Review request for lens. > > > Bugs: LENS-1391 > https://issues.apache.org/jira/browse/LENS-1391 > > > Repository: lens > > > Description > ------- > > MaxCoveringFactResolver and LeastPartitionResolver review comments > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java > c7f2047 > > lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java > 153df24 > > lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java > 4664cde > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java > fca86ec > > Diff: https://reviews.apache.org/r/56858/diff/ > > > Testing > ------- > > > Thanks, > > Lavkesh Lahngir > >
