----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56858/#review166148 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java (line 70) <https://reviews.apache.org/r/56858/#comment238032> This should be done at candidate level and not at storage candidate level. Candidate.getParticipatingPartitions().size() lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java (line 122) <https://reviews.apache.org/r/56858/#comment238033> passing null ? Should pass the incomplete partition details . This info will be stored in CandidateTablePruneCause#incompletePartitions and will be used for error message construction. lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java <https://reviews.apache.org/r/56858/#comment238034> Older comments seem more readable. Can you check once. lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java <https://reviews.apache.org/r/56858/#comment238035> Why this comment is dropped ? - Puneet Gupta On Feb. 21, 2017, 11:19 a.m., Lavkesh Lahngir wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56858/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2017, 11:19 a.m.) > > > Review request for lens. > > > Bugs: LENS-1391 > https://issues.apache.org/jira/browse/LENS-1391 > > > Repository: lens > > > Description > ------- > > MaxCoveringFactResolver and LeastPartitionResolver review comments > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java > c7f2047 > > lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java > 153df24 > > lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java > 4664cde > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java > fca86ec > > Diff: https://reviews.apache.org/r/56858/diff/ > > > Testing > ------- > > > Thanks, > > Lavkesh Lahngir > >
