> On Feb. 21, 2017, 11:19 a.m., Puneet Gupta wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java, > > line 70 > > <https://reviews.apache.org/r/56858/diff/2/?file=1640673#file1640673line70> > > > > This should be done at candidate level and not at storage candidate > > level. > > Candidate.getParticipatingPartitions().size()
Yeah. makes sense.. And the total size is equal to the addition of all the child parition sizes. > On Feb. 21, 2017, 11:19 a.m., Puneet Gupta wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java, > > line 125 > > <https://reviews.apache.org/r/56858/diff/2/?file=1640674#file1640674line125> > > > > passing null ? > > Should pass the incomplete partition details . This info will be stored > > in CandidateTablePruneCause#incompletePartitions and will be used for error > > message construction. hmm. This is at storageCandidate level not at candidate level. > On Feb. 21, 2017, 11:19 a.m., Puneet Gupta wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java, > > line 544 > > <https://reviews.apache.org/r/56858/diff/2/?file=1640675#file1640675line544> > > > > Why this comment is dropped ? Yeah.. I will put that again. > On Feb. 21, 2017, 11:19 a.m., Puneet Gupta wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java, > > lines 72-75 > > <https://reviews.apache.org/r/56858/diff/2/?file=1640675#file1640675line72> > > > > Older comments seem more readable. Can you check once. Yes.. I will undo it. - Lavkesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56858/#review166148 ----------------------------------------------------------- On Feb. 21, 2017, 11:19 a.m., Lavkesh Lahngir wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56858/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2017, 11:19 a.m.) > > > Review request for lens. > > > Bugs: LENS-1391 > https://issues.apache.org/jira/browse/LENS-1391 > > > Repository: lens > > > Description > ------- > > MaxCoveringFactResolver and LeastPartitionResolver review comments > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java > c7f2047 > > lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java > 153df24 > > lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java > 4664cde > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java > fca86ec > > Diff: https://reviews.apache.org/r/56858/diff/ > > > Testing > ------- > > > Thanks, > > Lavkesh Lahngir > >
