> On March 24, 2017, 3:59 p.m., Rajat Khandelwal wrote: > > lens-api/src/main/resources/cube-0.1.xsd > > Lines 184 (patched) > > <https://reviews.apache.org/r/57908/diff/2/?file=1673842#file1673842line184> > > > > By extending, we'll have to specify everything that we specify for fact > > table, which would mean columns would need to be provided. I don't think > > extension is something we need to use in this case. > > Rajitha R wrote: > Will do.
I agree. Extending fact doesnt look right. We should add new entity - with definition containing parent fact, base cube, start and end times, weight, the filter and properties. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57908/#review170019 ----------------------------------------------------------- On March 27, 2017, 9:55 a.m., Rajitha R wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57908/ > ----------------------------------------------------------- > > (Updated March 27, 2017, 9:55 a.m.) > > > Review request for lens and Rajat Khandelwal. > > > Repository: lens > > > Description > ------- > > Xsd for virtual fact > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd 060eb43 > lens-examples/src/main/resources/virtualfact1.xml PRE-CREATION > > > Diff: https://reviews.apache.org/r/57908/diff/4/ > > > Testing > ------- > > > Thanks, > > Rajitha R > >
