----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57908/#review170154 -----------------------------------------------------------
lens-examples/src/main/resources/virtualfact1.xml Lines 22 (patched) <https://reviews.apache.org/r/57908/#comment242943> We need to make weight mandatory. lens-examples/src/main/resources/virtualfact1.xml Lines 25 (patched) <https://reviews.apache.org/r/57908/#comment242942> I think filter will only be where clauses. conditions on measures are part of having clauses. We can keep one more property for having clauses. - Rajat Khandelwal On March 27, 2017, 3:25 p.m., Rajitha R wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57908/ > ----------------------------------------------------------- > > (Updated March 27, 2017, 3:25 p.m.) > > > Review request for lens and Rajat Khandelwal. > > > Repository: lens > > > Description > ------- > > Xsd for virtual fact > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd 060eb43 > lens-examples/src/main/resources/virtualfact1.xml PRE-CREATION > > > Diff: https://reviews.apache.org/r/57908/diff/4/ > > > Testing > ------- > > > Thanks, > > Rajitha R > >
