> On March 27, 2017, 11:24 a.m., Rajat Khandelwal wrote: > > lens-examples/src/main/resources/virtualfact1.xml > > Lines 22 (patched) > > <https://reviews.apache.org/r/57908/diff/4/?file=1676661#file1676661line22> > > > > We need to make weight mandatory.
Shoudn't we keep this optional. It can be borrowed from parent in that case ? - Puneet ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57908/#review170154 ----------------------------------------------------------- On March 27, 2017, 9:55 a.m., Rajitha R wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57908/ > ----------------------------------------------------------- > > (Updated March 27, 2017, 9:55 a.m.) > > > Review request for lens and Rajat Khandelwal. > > > Repository: lens > > > Description > ------- > > Xsd for virtual fact > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd 060eb43 > lens-examples/src/main/resources/virtualfact1.xml PRE-CREATION > > > Diff: https://reviews.apache.org/r/57908/diff/4/ > > > Testing > ------- > > > Thanks, > > Rajitha R > >
