----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57908/#review170530 -----------------------------------------------------------
lens-api/src/main/resources/cube-0.1.xsd Lines 179-180 (patched) <https://reviews.apache.org/r/57908/#comment243379> Are we planning to add this functionality, right now? If not, can you please remove this documentation. If we are adding, can we build more clarity on the usecase? lens-examples/src/main/resources/virtualfact1.xml Lines 25-26 (patched) <https://reviews.apache.org/r/57908/#comment243380> Should these be fields on cube or fields on fact? If fields from fact, then expresssions or join chains defined in cube, may not be getting used. I feel these should be from cube fields, to give users more control. - Amareshwari Sriramadasu On March 28, 2017, 7:22 a.m., Rajitha R wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57908/ > ----------------------------------------------------------- > > (Updated March 28, 2017, 7:22 a.m.) > > > Review request for lens and Rajat Khandelwal. > > > Repository: lens > > > Description > ------- > > Xsd for virtual fact > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd 060eb43 > lens-examples/src/main/resources/virtualfact1.xml PRE-CREATION > > > Diff: https://reviews.apache.org/r/57908/diff/5/ > > > Testing > ------- > > > Thanks, > > Rajitha R > >
