----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28555/#review63506 -----------------------------------------------------------
Some comments on the approach: * queriedFactStorageTables in CubeQueryContext doesnt look right. We already have pickedFact and its storage tables in the candidateFact. * HQLContext classes should not get CubeQueryContext. - Amareshwari Sriramadasu On Dec. 2, 2014, 8:58 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28555/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2014, 8:58 a.m.) > > > Review request for lens. > > > Bugs: LENS-33 > https://issues.apache.org/jira/browse/LENS-33 > > > Repository: lens > > > Description > ------- > > checkpoint > > > checkpoint > > > Merge branch 'master' of github.com:apache/incubator-lens into LENS-33 > > > checkpoint > > > merge master > > > Merge branch 'master' of github.com:apache/incubator-lens into LENS-33 > > > Merge branch 'master' of github.com:apache/incubator-lens into LENS-33 > > > checkpoint WIP > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 0a6f489 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > 2409db8 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java > 1325c05 > lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java > 0070ec2 > lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java > 88a1b7d > lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java > a7819c1 > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLContextInterface.java > fb196cc > lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java > 7afe82e > lens-cube/src/main/java/org/apache/lens/cube/parse/SimpleHQLContext.java > f067d0a > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > 3fb9d09 > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageUtil.java 01cfcf7 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java > e24e0bc > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > 17ae4c0 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java > ee6f00f > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java > 173c458 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java > 492ce68 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java > f68715f > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java > 2661380 > lens-cube/src/test/java/org/apache/lens/driver/cube/TestRewriting.java > 796a582 > > Diff: https://reviews.apache.org/r/28555/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
