> On Dec. 2, 2014, 11:34 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java, line > > 54 > > <https://reviews.apache.org/r/28555/diff/5/?file=780037#file780037line54> > > > > Is CubeQueryContext still required in getReferences()?
Yes. The two derived classes of DimHQLContext both have CubeQueyContext and if we keep it that way then it leads to code duplication. > On Dec. 2, 2014, 11:34 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java, line > > 82 > > <https://reviews.apache.org/r/28555/diff/5/?file=780037#file780037line82> > > > > Are these newly added methods used anywhere? Yes. In getFromString. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28555/#review63519 ----------------------------------------------------------- On Dec. 2, 2014, 2:04 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28555/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2014, 2:04 p.m.) > > > Review request for lens. > > > Bugs: LENS-33 > https://issues.apache.org/jira/browse/LENS-33 > > > Repository: lens > > > Description > ------- > > checkpoint > > > checkpoint > > > Merge branch 'master' of github.com:apache/incubator-lens into LENS-33 > > > checkpoint > > > merge master > > > Merge branch 'master' of github.com:apache/incubator-lens into LENS-33 > > > Merge branch 'master' of github.com:apache/incubator-lens into LENS-33 > > > checkpoint WIP > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java > ad6d3fb > lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java > 0070ec2 > lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java > 88a1b7d > lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java > a7819c1 > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageUtil.java 01cfcf7 > > Diff: https://reviews.apache.org/r/28555/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
