----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28555/#review63536 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java <https://reviews.apache.org/r/28555/#comment105803> Can we reuse methods getTimeDimOfPartitionColumn and getPartitionColumnOfTimeDim in CubeQueryContext? I'm fine moving them to cube and derivedcube directly Overall changes look fine. Can you update tests also? - Amareshwari Sriramadasu On Dec. 2, 2014, 2:09 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28555/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2014, 2:09 p.m.) > > > Review request for lens. > > > Bugs: LENS-33 > https://issues.apache.org/jira/browse/LENS-33 > > > Repository: lens > > > Description > ------- > > checkpoint > > > checkpoint > > > Merge branch 'master' of github.com:apache/incubator-lens into LENS-33 > > > checkpoint > > > merge master > > > Merge branch 'master' of github.com:apache/incubator-lens into LENS-33 > > > Merge branch 'master' of github.com:apache/incubator-lens into LENS-33 > > > checkpoint WIP > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java > ad6d3fb > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > 2409db8 > lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java > 0070ec2 > lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java > 88a1b7d > lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java > a7819c1 > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageUtil.java 01cfcf7 > > Diff: https://reviews.apache.org/r/28555/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
