> On Dec. 29, 2014, 9:16 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java, line > > 31 > > <https://reviews.apache.org/r/29451/diff/1/?file=802160#file802160line31> > > > > I'm thinking some expressions might contain | in the expression. > > > > What is good delimiter for separating expressions? > > It should not be part of expression itself. > > > > Almost all the special characters can be used in expression itself. I'm > > thinking should we have some escaping for the delimiter added? Or do some > > encoding of the expression to Base64 or something and decode when > > deserializing? > > > > Thoughts?
We can also use a long string like "__expr__" > On Dec. 29, 2014, 9:16 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java, line > > 176 > > <https://reviews.apache.org/r/29451/diff/1/?file=802160#file802160line176> > > > > we need to do propreties.put for expression key. Ok will do. - Jaideep ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29451/#review66238 ----------------------------------------------------------- On Dec. 29, 2014, 8:31 a.m., Jaideep dhok wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29451/ > ----------------------------------------------------------- > > (Updated Dec. 29, 2014, 8:31 a.m.) > > > Review request for lens. > > > Bugs: LENS-175 > https://issues.apache.org/jira/browse/LENS-175 > > > Repository: lens > > > Description > ------- > > Changes in ExprColumn and test changes to validate multiple expressions. No > changes required in CubeMetastoreClient > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java > 352fef9 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 5889506 > > Diff: https://reviews.apache.org/r/29451/diff/ > > > Testing > ------- > > Added new tests for creating and altering multiple expressions. > No impact on existing lens-cube tests. I'll update JIRA with complete test > report. > > > Thanks, > > Jaideep dhok > >
